<html>
<head><meta charset="utf-8"><title>Looking to contribute · wg-traits · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/index.html">wg-traits</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html">Looking to contribute</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="194942424"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194942424" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194942424">(Apr 22 2020 at 14:48)</a>:</h4>
<p>Hi!<br>
I'm interested in contributing to chalk and anything related to GATs. I have searched for some easy issues to get me started, but can't seem to find any that haven't already been claimed. Does anyone have pointers as to what a first time contributor like me could work on to familiarize oneself with the codebase?</p>



<a name="194948070"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194948070" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194948070">(Apr 22 2020 at 15:27)</a>:</h4>
<p>Hi, welcome <span aria-label="slight smile" class="emoji emoji-1f642" role="img" title="slight smile">:slight_smile:</span></p>



<a name="194948210"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194948210" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194948210">(Apr 22 2020 at 15:28)</a>:</h4>
<p>Looking at the <a href="https://rust-lang.github.io/wg-traits/roadmap/skill-tree.html" title="https://rust-lang.github.io/wg-traits/roadmap/skill-tree.html">skill tree</a>, we have a rough idea what needs to happen around GATs, but I'm not sure whether any of them are simple enough to start out with</p>



<a name="194948888"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194948888" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194948888">(Apr 22 2020 at 15:33)</a>:</h4>
<p>There's also <a href="https://github.com/rust-lang/chalk/pull/362" title="https://github.com/rust-lang/chalk/pull/362">a PR with the <code>good first issue</code> label</a> ( <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span> ), to finish the tracing setup</p>



<a name="194949018"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194949018" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194949018">(Apr 22 2020 at 15:34)</a>:</h4>
<p>Other than that, I'm sure there's work to be picked up, we just haven't created the issues for them yet</p>



<a name="194951447"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194951447" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Areredify <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194951447">(Apr 22 2020 at 15:51)</a>:</h4>
<p>Adding <code>Fn</code> trait support is also on the table</p>



<a name="194951917"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194951917" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194951917">(Apr 22 2020 at 15:54)</a>:</h4>
<p>Awesome, thanks! :)<br>
I will look into that PR, seems perfect. If I read the issue/PR correctly: basically add <code>tracing</code> support for relevant parts of <code>chalk-engine</code>?</p>



<a name="194951971"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194951971" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Areredify <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194951971">(Apr 22 2020 at 15:55)</a>:</h4>
<p>You can look at my pr's with Sized and Copy implementations, you will probably also need to look at rustc code that handles the <code>Fn</code> trait</p>



<a name="194952396"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194952396" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194952396">(Apr 22 2020 at 15:58)</a>:</h4>
<p>Oh, sorry. I was referring to the PR linked by detrumi <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="194953009"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194953009" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Areredify <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194953009">(Apr 22 2020 at 16:01)</a>:</h4>
<p>Yeah I understand, I wasn't answering to you message, just providing general info about the issue</p>



<a name="194953018"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194953018" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194953018">(Apr 22 2020 at 16:01)</a>:</h4>
<p>All good, with any luck someone else gets interested and picks that up (<span class="user-mention" data-user-id="251766">@Areredify</span> you should make an issue for Fn support))</p>



<a name="194953244"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194953244" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Areredify <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194953244">(Apr 22 2020 at 16:02)</a>:</h4>
<p>It's already there, just <a href="https://github.com/rust-lang/chalk/issues/363" title="https://github.com/rust-lang/chalk/issues/363">hidden</a></p>



<a name="194955983"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194955983" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194955983">(Apr 22 2020 at 16:22)</a>:</h4>
<p><span class="user-mention" data-user-id="295706">@Christofer Nolander</span> Yes, the PR basically just adds tracing support for chalk-engine</p>



<a name="194955997"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194955997" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194955997">(Apr 22 2020 at 16:22)</a>:</h4>
<p>But also other chalk crates I think</p>



<a name="194956130"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194956130" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194956130">(Apr 22 2020 at 16:23)</a>:</h4>
<p>For some context, there's already a stream for it: <a href="#narrow/stream/144729-wg-traits/topic/tracing.20in.20chalk/near/192424178" title="#narrow/stream/144729-wg-traits/topic/tracing.20in.20chalk/near/192424178">https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/tracing.20in.20chalk/near/192424178</a></p>



<a name="194956148"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194956148" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194956148">(Apr 22 2020 at 16:24)</a>:</h4>
<p>If you have questions, feel free to ask :)</p>



<a name="194956888"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194956888" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194956888">(Apr 22 2020 at 16:29)</a>:</h4>
<p>Great, thanks! Suddenly I have a lot of reading to look forward to :)</p>



<a name="194979142"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194979142" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194979142">(Apr 22 2020 at 19:23)</a>:</h4>
<p>Ok, so I have converted whatever stderr logging I could find to tracing (I was not brave enough to add any new logging though :P)</p>



<a name="194979273"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194979273" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194979273">(Apr 22 2020 at 19:24)</a>:</h4>
<p>Now for the tough part: how do I push my changes to <span class="user-mention" data-user-id="198819">@David Barsky</span>'s PR?</p>



<a name="194979330"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194979330" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194979330">(Apr 22 2020 at 19:25)</a>:</h4>
<p><span class="user-mention" data-user-id="295706">@Christofer Nolander</span> I can give you permissions to my fork?</p>



<a name="194979416"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194979416" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194979416">(Apr 22 2020 at 19:26)</a>:</h4>
<p>Sure, that works</p>



<a name="194979616"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194979616" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194979616">(Apr 22 2020 at 19:27)</a>:</h4>
<p>What's your github alias?</p>



<a name="194979663"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194979663" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194979663">(Apr 22 2020 at 19:27)</a>:</h4>
<p>"nolanderc"</p>



<a name="194979844"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194979844" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194979844">(Apr 22 2020 at 19:29)</a>:</h4>
<p>invited!</p>



<a name="194979862"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194979862" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194979862">(Apr 22 2020 at 19:29)</a>:</h4>
<p>once you accept, you should be able to push to my branch/PR.</p>



<a name="194980050"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194980050" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194980050">(Apr 22 2020 at 19:30)</a>:</h4>
<p>Nice, let's hope this works :)</p>



<a name="194980370"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194980370" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194980370">(Apr 22 2020 at 19:32)</a>:</h4>
<p>Hmm, somehow I pushed to the <code>david/add-tracing</code> branch instead of <code>add-tracing</code>, any ideas?</p>



<a name="194980432"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194980432" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194980432">(Apr 22 2020 at 19:33)</a>:</h4>
<p>(pushed using <code>git push david add-tracing</code> where <code>david</code> is the name of the remote to your repo)</p>



<a name="194982213"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194982213" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194982213">(Apr 22 2020 at 19:47)</a>:</h4>
<p>There we go, that was really confusing, apparently I was pushing to <code>add-tracing</code> but I was supposed to push to <code>david/add-tracing</code>. No idea how GitHub figured out that I used <code>david</code> as an alias though.</p>



<a name="194982984"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194982984" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194982984">(Apr 22 2020 at 19:53)</a>:</h4>
<p>yup, it's meant to be push to <code>david/add-tracing</code>, but glad you got it.</p>



<a name="194988461"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194988461" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194988461">(Apr 22 2020 at 20:39)</a>:</h4>
<p><span class="user-mention" data-user-id="295706">@Christofer Nolander</span> PR is looking good :)</p>



<a name="194988495"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194988495" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194988495">(Apr 22 2020 at 20:39)</a>:</h4>
<p>It might be easier to just open up your own PR, and we can close <span class="user-mention" data-user-id="198819">@David Barsky</span>'s</p>



<a name="194988523"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194988523" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194988523">(Apr 22 2020 at 20:39)</a>:</h4>
<p>that also works!</p>



<a name="194988732"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194988732" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194988732">(Apr 22 2020 at 20:41)</a>:</h4>
<p>Also, do you think you could update this snippet about debugging? <a href="https://github.com/rust-lang/chalk/blob/master/book/src/contribution_guide.md#running-and-debugging" title="https://github.com/rust-lang/chalk/blob/master/book/src/contribution_guide.md#running-and-debugging">https://github.com/rust-lang/chalk/blob/master/book/src/contribution_guide.md#running-and-debugging</a></p>



<a name="194988754"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194988754" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194988754">(Apr 22 2020 at 20:41)</a>:</h4>
<p>i.e. just a quick note about how to actually see the output and such</p>



<a name="194989081"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194989081" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194989081">(Apr 22 2020 at 20:45)</a>:</h4>
<p>Sure, however, when/where should we actually print the output?</p>



<a name="194989114"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194989114" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194989114">(Apr 22 2020 at 20:45)</a>:</h4>
<p>The tests currently include a catch-all dump to stderr, should there also be one in <code>chalk/src/main.rs</code>?</p>



<a name="194989190"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194989190" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194989190">(Apr 22 2020 at 20:46)</a>:</h4>
<p>So with <code>CHALK_DEBUG</code>, it's just written to stderr</p>



<a name="194989208"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194989208" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194989208">(Apr 22 2020 at 20:46)</a>:</h4>
<p>I'm not set on any one way</p>



<a name="194989247"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194989247" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194989247">(Apr 22 2020 at 20:46)</a>:</h4>
<p>I would just say that it would be nice to have documentation on how I would, for example, display debug output when running from rustc</p>



<a name="194989310"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194989310" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194989310">(Apr 22 2020 at 20:47)</a>:</h4>
<p>(which, fyi, goes through <code>chalk-solve</code>)</p>



<a name="194989676"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194989676" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194989676">(Apr 22 2020 at 20:50)</a>:</h4>
<p>Hmm, the idea behind <code>tracing</code> is that libraries shouldn`t have to worry about when and what to print. Instead that should go into the executable (using a subscriber <a href="https://crates.io/crates/tracing-subscriber" title="https://crates.io/crates/tracing-subscriber">https://crates.io/crates/tracing-subscriber</a>)</p>



<a name="194989741"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194989741" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194989741">(Apr 22 2020 at 20:51)</a>:</h4>
<p>So preferably there should be a switch inside rustc that enables/disables debug output</p>



<a name="194989904"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194989904" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194989904">(Apr 22 2020 at 20:52)</a>:</h4>
<p>I <em>believe</em> that rustc uses <code>log</code> internally and <span class="user-mention" data-user-id="119009">@eddyb</span> wasn't opposed to switching the logger in rustc to something provided by <code>tracing</code>.</p>



<a name="194989955"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194989955" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194989955">(Apr 22 2020 at 20:53)</a>:</h4>
<p>But even so, data emitted by <code>tracing</code> can be consumed by <code>log</code>-compliant loggers without issue.</p>



<a name="194990108"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194990108" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194990108">(Apr 22 2020 at 20:54)</a>:</h4>
<p>There was some discussion in a previously linked thread about using a custom logger that displayed the different nesting levels, might be something to look deeper into</p>



<a name="194990158"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194990158" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194990158">(Apr 22 2020 at 20:55)</a>:</h4>
<p>which reminds me, i need to publish that logger in question to <a href="http://crates.io" title="http://crates.io">crates.io</a></p>



<a name="194990163"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194990163" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194990163">(Apr 22 2020 at 20:55)</a>:</h4>
<p>Right, so essentially right now, if I run <code>CHALK_DEBUG=2 ./x.py test ...</code> for rustc</p>



<a name="194990196"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194990196" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194990196">(Apr 22 2020 at 20:55)</a>:</h4>
<p>I guess, would that still be more or less possible?</p>



<a name="194990203"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194990203" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194990203">(Apr 22 2020 at 20:55)</a>:</h4>
<p>(it's this thing, for reference: <a href="https://github.com/davidbarsky/tracing-tree/" title="https://github.com/davidbarsky/tracing-tree/">https://github.com/davidbarsky/tracing-tree/</a>)</p>



<a name="194990317"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194990317" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194990317">(Apr 22 2020 at 20:56)</a>:</h4>
<p>For now I can restore the previous behavior (with <code>CHALK_DEBUG</code>), at least in the tests and the executable. Not sure where to do things in the compiler at the moment</p>



<a name="194991382"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194991382" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194991382">(Apr 22 2020 at 21:06)</a>:</h4>
<p>Is it "good" to conditionally wrap the solver with a subscriber based on and environment variable</p>



<a name="194991424"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194991424" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194991424">(Apr 22 2020 at 21:06)</a>:</h4>
<p><span class="user-mention" data-user-id="232957">@Jack Huey</span> is that directed for me, or...?</p>



<a name="194991617"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194991617" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194991617">(Apr 22 2020 at 21:08)</a>:</h4>
<p>Anyone who knows lol</p>



<a name="194992036"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194992036" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194992036">(Apr 22 2020 at 21:12)</a>:</h4>
<p>How does rustc do debug output in other components?</p>



<a name="194992144"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194992144" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194992144">(Apr 22 2020 at 21:13)</a>:</h4>
<p>good question, I don't know</p>



<a name="194992660"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194992660" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194992660">(Apr 22 2020 at 21:18)</a>:</h4>
<p>the short of it is that it's a <em>bit</em> hairy to load loggers or subscribers conditionally on an env variable. you can!</p>



<a name="194992759"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194992759" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194992759">(Apr 22 2020 at 21:19)</a>:</h4>
<p>actually, now that I think of it, I'm not sure its as hairy as I thought it'd be. just ugly.</p>



<a name="194992780"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194992780" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194992780">(Apr 22 2020 at 21:19)</a>:</h4>
<p>I'm aware that some <code>log</code> loggers allow you to filter based on crates/modules</p>



<a name="194992792"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194992792" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194992792">(Apr 22 2020 at 21:19)</a>:</h4>
<p>Not sure if there's a similar concept for <code>tracing</code></p>



<a name="194992906"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194992906" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194992906">(Apr 22 2020 at 21:20)</a>:</h4>
<p>there is!</p>



<a name="194992996"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194992996" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194992996">(Apr 22 2020 at 21:21)</a>:</h4>
<p>So if we were to switch rustc over to use <code>tracing</code>, maybe that's a viable route?</p>



<a name="194993082"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194993082" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194993082">(Apr 22 2020 at 21:22)</a>:</h4>
<p>there are two flavors:</p>
<ol>
<li>envfilter (<a href="https://docs.rs/tracing-subscriber/0.2.5/tracing_subscriber/filter/struct.EnvFilter.html" title="https://docs.rs/tracing-subscriber/0.2.5/tracing_subscriber/filter/struct.EnvFilter.html">https://docs.rs/tracing-subscriber/0.2.5/tracing_subscriber/filter/struct.EnvFilter.html</a>), which mimics the current environment variable syntax and behavior.</li>
<li>there's also a reload one, which given some configuration "endpoint", you'd be able to reload filtering behavior at runtime: <a href="https://docs.rs/tracing-subscriber/0.2.5/tracing_subscriber/reload/index.html" title="https://docs.rs/tracing-subscriber/0.2.5/tracing_subscriber/reload/index.html">https://docs.rs/tracing-subscriber/0.2.5/tracing_subscriber/reload/index.html</a></li>
</ol>



<a name="194993212"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194993212" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194993212">(Apr 22 2020 at 21:23)</a>:</h4>
<p><code>tracing</code>'s filters are a bit richer than log's: <a href="https://docs.rs/tracing-subscriber/0.2.5/tracing_subscriber/filter/struct.EnvFilter.html#examples" title="https://docs.rs/tracing-subscriber/0.2.5/tracing_subscriber/filter/struct.EnvFilter.html#examples">https://docs.rs/tracing-subscriber/0.2.5/tracing_subscriber/filter/struct.EnvFilter.html#examples</a></p>



<a name="194993324"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194993324" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194993324">(Apr 22 2020 at 21:25)</a>:</h4>
<p>there's the standard <code>[module=info]</code> filtering, but you can also narrow down to a specific unit of work.</p>



<a name="194993385"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194993385" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194993385">(Apr 22 2020 at 21:25)</a>:</h4>
<p>I also realize that the grammar is a bit adhoc for this. pretty sure it's implemented using a regex.</p>



<a name="194993512"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194993512" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194993512">(Apr 22 2020 at 21:26)</a>:</h4>
<p>Opened a new PR: <a href="https://github.com/rust-lang/chalk/pull/409" title="https://github.com/rust-lang/chalk/pull/409">https://github.com/rust-lang/chalk/pull/409</a></p>



<a name="194993526"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194993526" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194993526">(Apr 22 2020 at 21:27)</a>:</h4>
<p>Someone might want to close the old one</p>



<a name="194993555"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194993555" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194993555">(Apr 22 2020 at 21:27)</a>:</h4>
<p>I'll close out the old one.</p>



<a name="194993592"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194993592" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194993592">(Apr 22 2020 at 21:27)</a>:</h4>
<p>done.</p>



<a name="194993846"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194993846" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194993846">(Apr 22 2020 at 21:30)</a>:</h4>
<p>Hmmm, now why am I getting all these conflicts, they weren't there in the previous PR...</p>



<a name="194994810"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194994810" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194994810">(Apr 22 2020 at 21:40)</a>:</h4>
<p>Different base probably</p>



<a name="194994851"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194994851" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194994851">(Apr 22 2020 at 21:41)</a>:</h4>
<p>There's been a good amount of changes on master</p>



<a name="194995350"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194995350" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194995350">(Apr 22 2020 at 21:47)</a>:</h4>
<p>Oh, is this one of those situations when you should rebase?</p>



<a name="194995410"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194995410" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194995410">(Apr 22 2020 at 21:47)</a>:</h4>
<p>yes</p>



<a name="194998005"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194998005" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194998005">(Apr 22 2020 at 22:16)</a>:</h4>
<p>I successfully rebased my local branch onto master, but now I can't push to my fork anymore since they have diverged</p>



<a name="194998022"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194998022" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194998022">(Apr 22 2020 at 22:17)</a>:</h4>
<p>Is there a way to resolve this without force pushing my local changes?</p>



<a name="194998123"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194998123" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mark Drobnak <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194998123">(Apr 22 2020 at 22:18)</a>:</h4>
<p>Rebasing an already-pushed branch requires a force push</p>



<a name="194998260"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194998260" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194998260">(Apr 22 2020 at 22:20)</a>:</h4>
<p>Is that safe to do in this case?</p>



<a name="194998488"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194998488" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> David Barsky <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194998488">(Apr 22 2020 at 22:22)</a>:</h4>
<p>should be—it only affects your branch.</p>



<a name="194998492"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194998492" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mark Drobnak <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194998492">(Apr 22 2020 at 22:22)</a>:</h4>
<p>As long as you aren't missing commits locally and as long as no one else is working on the branch.</p>



<a name="194998738"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194998738" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194998738">(Apr 22 2020 at 22:25)</a>:</h4>
<p>Okay, seems to have worked fine, thanks!</p>



<a name="194998822"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194998822" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194998822">(Apr 22 2020 at 22:26)</a>:</h4>
<p>By the way, is it possible to avoid force pushing when rebasing, if so, how?</p>



<a name="194999000"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194999000" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194999000">(Apr 22 2020 at 22:28)</a>:</h4>
<p>not rebasing</p>



<a name="194999052"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/194999052" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#194999052">(Apr 22 2020 at 22:29)</a>:</h4>
<p>x)</p>



<a name="195547281"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/195547281" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#195547281">(Apr 28 2020 at 11:02)</a>:</h4>
<p>I will be adding some documentation for how to use <code>tracing</code> within the codebase to the book. Where in the book should I put this?</p>



<a name="195547423"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/195547423" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christofer Nolander <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#195547423">(Apr 28 2020 at 11:03)</a>:</h4>
<p>Chapter 2 of the book "Contribution Guide" feels like the right place, but seems to be too minimal for the amount of documentation that would be required. Should I add a new subchapter instead?</p>



<a name="195547703"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/195547703" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#195547703">(Apr 28 2020 at 11:06)</a>:</h4>
<p>Yeah, subchapter 2.1 seems like a good spot</p>



<a name="195547867"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/195547867" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#195547867">(Apr 28 2020 at 11:08)</a>:</h4>
<p>We should add more subchapters there anyways, such as more info on debugging chalk</p>



<a name="205163670"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205163670" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205163670">(Jul 27 2020 at 20:20)</a>:</h4>
<p>Hi! I'd be willing to help in this WG, but I don't know what I could help with. I only made a few minor contributions to rustc and have no theoretical knowledge in computer science or type theory. I also skimmed through the Chalk book, though I will need to come back to it with my dear friends paper and pencil <span aria-label="note" class="emoji emoji-1f4dd" role="img" title="note">:note:</span>. Any advice would be appreciated <span aria-label="blush" class="emoji emoji-1f60a" role="img" title="blush">:blush:</span></p>



<a name="205165942"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205165942" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205165942">(Jul 27 2020 at 20:42)</a>:</h4>
<p>Anything in particular you're interested in?</p>



<a name="205166194"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205166194" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205166194">(Jul 27 2020 at 20:44)</a>:</h4>
<p>Mhh, I can't think of anything in particular</p>



<a name="205166264"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205166264" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205166264">(Jul 27 2020 at 20:45)</a>:</h4>
<p>Let me see if I can find a good issue to start with</p>



<a name="205166283"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205166283" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205166283">(Jul 27 2020 at 20:45)</a>:</h4>
<p>By the way, in <a href="https://github.com/rust-lang/wg-traits/issues/16">wg-traits#16</a>:</p>
<blockquote>
<p>Refactor code in rustc using ty.kind to use a method ty.kind(tcx)</p>
<p>Adapt rustc to use ty.kind(tcx) instead of ty.kind</p>
</blockquote>
<p>Aren't these two steps duplicates?</p>



<a name="205166333"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205166333" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205166333">(Jul 27 2020 at 20:46)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232957">Jack Huey</span> <a href="#narrow/stream/144729-wg-traits/topic/Looking.20to.20contribute/near/205166264">said</a>:</p>
<blockquote>
<p>Let me see if I can find a good issue to start with</p>
</blockquote>
<p>Thanks a lot!</p>



<a name="205166359"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205166359" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205166359">(Jul 27 2020 at 20:46)</a>:</h4>
<p>haha yep, good catch</p>



<a name="205166408"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205166408" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205166408">(Jul 27 2020 at 20:47)</a>:</h4>
<p><em>That</em> actually might be issue to work on?</p>



<a name="205166415"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205166415" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205166415">(Jul 27 2020 at 20:47)</a>:</h4>
<p>If you want to work on rustc</p>



<a name="205166427"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205166427" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205166427">(Jul 27 2020 at 20:47)</a>:</h4>
<p>If you want to work on Chalk, I can keep looking</p>



<a name="205166511"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205166511" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205166511">(Jul 27 2020 at 20:48)</a>:</h4>
<p>I'm fine with both, I can start looking at this</p>



<a name="205166520"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205166520" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205166520">(Jul 27 2020 at 20:48)</a>:</h4>
<p>There's also some other rustc work that I have put off</p>



<a name="205166528"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205166528" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205166528">(Jul 27 2020 at 20:48)</a>:</h4>
<p>But this is a good, simple thing to start with</p>



<a name="205166542"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205166542" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205166542">(Jul 27 2020 at 20:48)</a>:</h4>
<p>Great, thanks again!</p>



<a name="205166674"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205166674" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205166674">(Jul 27 2020 at 20:50)</a>:</h4>
<p>Of course :)</p>



<a name="205166691"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205166691" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205166691">(Jul 27 2020 at 20:50)</a>:</h4>
<p>I'm sure <span class="user-mention" data-user-id="116009">@nikomatsakis</span> will be happy to see someone is working on this lol</p>



<a name="205167137"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205167137" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205167137">(Jul 27 2020 at 20:55)</a>:</h4>
<p>Five minutes later and I already found <a href="https://zulip-archive.rust-lang.org/131828tcompiler/05771designmeeting20200306.html#189906441">this</a> :D</p>



<a name="205167288"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205167288" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205167288">(Jul 27 2020 at 20:56)</a>:</h4>
<p>haha</p>



<a name="205185412"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205185412" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nathan Whitaker <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205185412">(Jul 28 2020 at 00:42)</a>:</h4>
<p>I think I remember seeing in the sprint doc that the refactoring might also require a compiler team MCP? Doesn't necessarily block the work, but I think it might need to get filed eventually</p>



<a name="205185463"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205185463" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nathan Whitaker <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205185463">(Jul 28 2020 at 00:42)</a>:</h4>
<p>(Just thinking out loud)</p>



<a name="205198719"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205198719" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Areredify <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205198719">(Jul 28 2020 at 05:08)</a>:</h4>
<p>It absolutely will require it I think, it's a pretty fundamental change</p>



<a name="205208055"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205208055" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205208055">(Jul 28 2020 at 08:16)</a>:</h4>
<p>Should I go ahead and open an MCP myself?</p>



<a name="205213758"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205213758" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205213758">(Jul 28 2020 at 09:21)</a>:</h4>
<p>Would that be one MCP for these 4 steps together?</p>
<blockquote>
<p>So, a sketch for a plan in rustc (each step is a PR):<br>
1. ty.kind -&gt; ty.kind()<br>
2. ty.kind()-&gt; ty.kind(tcx)<br>
3. Add a type alias and make kind work on I: Interner<br>
4. Start using Ty&lt;I&gt; more (This is a lot of PRs)</p>
</blockquote>



<a name="205215400"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205215400" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Areredify <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205215400">(Jul 28 2020 at 09:39)</a>:</h4>
<p>I feel like yes, because structurally thats a single change (make rustc use an interner for type kind), those steps are just implementation milestones. It's not like we can do half of them and then decide we don't want to do the rest and leave it at that. If we discover some problems while implementing we will probably redesign the whole thing, I can't see the benefit of discussing those changes one by one in different mcps</p>



<a name="205216001"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205216001" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205216001">(Jul 28 2020 at 09:45)</a>:</h4>
<p>I probably missed where this was discussed, by why is the interner needed in <code>ty.kind</code> and not in <code>mk_ty</code>? (nm that)</p>



<a name="205216090"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205216090" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205216090">(Jul 28 2020 at 09:46)</a>:</h4>
<p>why do we need <code>tcx</code> in kind</p>



<a name="205216105"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205216105" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205216105">(Jul 28 2020 at 09:46)</a>:</h4>
<p>is the question I wanted to ask <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="205217383"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205217383" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Areredify <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205217383">(Jul 28 2020 at 09:59)</a>:</h4>
<p>Correct me if Im wrong, but the idea is to essentially make ty into [small] opaque handle</p>



<a name="205217387"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205217387" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205217387">(Jul 28 2020 at 09:59)</a>:</h4>
<p><span class="user-mention" data-user-id="216206">@lcnr</span> I think it was discussed in <a href="https://zulip-archive.rust-lang.org/131828tcompiler/05771designmeeting20200306.html">this meeting</a></p>



<a name="205217482"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205217482" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205217482">(Jul 28 2020 at 10:00)</a>:</h4>
<p>These <a href="https://rust-lang.github.io/compiler-team/minutes/design-meeting/2020-03-12-shared-library-for-types/">meeting notes</a> are probably good context</p>



<a name="205217550"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205217550" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Areredify <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205217550">(Jul 28 2020 at 10:01)</a>:</h4>
<p>And to get the data about a type you request it from an interner</p>



<a name="205217675"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205217675" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205217675">(Jul 28 2020 at 10:02)</a>:</h4>
<blockquote>
<p>To actually use a type, you wish to invoke the data() method (you have to supply a reference to the interner):</p>
</blockquote>
<div class="codehilite"><pre><span></span><code>impl&lt;I: Interner&gt; Ty&lt;I&gt; {
    pub fn data(&amp;self, interner: &amp;I) -&gt; &amp;TyData&lt;I&gt; {
        interner.lookup_ty_data(&amp;self.interned)
    }
</code></pre></div>



<a name="205217758"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205217758" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205217758">(Jul 28 2020 at 10:03)</a>:</h4>
<p>So is the <code>tcx</code> in rustc the same as the interner here?</p>



<a name="205218039"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205218039" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Areredify <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205218039">(Jul 28 2020 at 10:06)</a>:</h4>
<p>That was my impression</p>



<a name="205219732"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205219732" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205219732">(Jul 28 2020 at 10:27)</a>:</h4>
<p>So from what I can tell the reason for adding for adding the interner as an argument to <code>ty.kind/data</code> is mostly to allow what rust-analyzer is doing</p>
<blockquote>
<p>rust-analyzer presently uses a form of interning where types are represented as an integer, and that is integrated into the incremental system to allow recycling integers when things change etc)</p>
</blockquote>



<a name="205220343"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205220343" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205220343">(Jul 28 2020 at 10:35)</a>:</h4>
<p>I still kind of dislike this, but probably have to see how this interacts with <code>GenericArg</code> and stuff to form a more complete opinion here.</p>



<a name="205220605"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205220605" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Florian Diebold <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205220605">(Jul 28 2020 at 10:38)</a>:</h4>
<p>hmm where is that from? I'm either misunderstanding it, or it's not true. rust-analyzer doesn't intern types currently, we just put them into <code>Arc</code>s. We do intern definitions and things like that as numbers though</p>



<a name="205220649"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205220649" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Florian Diebold <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205220649">(Jul 28 2020 at 10:38)</a>:</h4>
<p>so maybe that's what was meant, it does mean we need the database to access information about ADTs for example</p>



<a name="205220692"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205220692" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Florian Diebold <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205220692">(Jul 28 2020 at 10:39)</a>:</h4>
<p>yeah the quote mostly makes sense if you replace "types" by "defs"</p>



<a name="205220813"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205220813" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Florian Diebold <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205220813">(Jul 28 2020 at 10:40)</a>:</h4>
<p>accessing the type kind doesn't require the database in RA though</p>



<a name="205221930"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205221930" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205221930">(Jul 28 2020 at 10:56)</a>:</h4>
<p>from here <a href="#narrow/stream/131828-t-compiler/topic/design.20meeting.202020-03-06/near/189902462">https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/design.20meeting.202020-03-06/near/189902462</a></p>



<a name="205748590"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/Looking%20to%20contribute/near/205748590" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/Looking.20to.20contribute.html#205748590">(Aug 02 2020 at 23:26)</a>:</h4>
<p>FYI, I just filed <a href="https://github.com/rust-lang/rust/issues/75077">#75077</a> but I forgot to adapt rustdoc as well</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>